Skip to content

BUG/TST: sorting of NaNs on sym_diff #6453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2014

Conversation

TomAugspurger
Copy link
Contributor

Closes #6444, which was failing on Python 3.4

I don't actually have python 3.4 running yet, virtualenv is complaining about my 3.4 executable. These test should pass on 2.6+.

I put the release note under the bug section, but I can move it to the API section if you think that's more appropriate.

jreback added a commit that referenced this pull request Feb 23, 2014
BUG/TST: sorting of NaNs on sym_diff
@jreback jreback merged commit 5a3076a into pandas-dev:master Feb 23, 2014
@jreback
Copy link
Contributor

jreback commented Feb 23, 2014

thanks.....

@jreback
Copy link
Contributor

jreback commented Feb 23, 2014

@TomAugspurger I confirm this is all fixed (on the windows 3.4 build)..thanks!

@TomAugspurger
Copy link
Contributor Author

Thanks for testing it.

On Feb 23, 2014, at 5:31 PM, "jreback" <[email protected]mailto:[email protected]> wrote:

@TomAugspurgerhttps://github.com/TomAugspurger I confirm this is all fixed (on the windows 3.4 build)..thanks!


Reply to this email directly or view it on GitHubhttps://github.com//pull/6453#issuecomment-35848054.

@jreback
Copy link
Contributor

jreback commented Feb 23, 2014

np....as an aside...would you be interested in setting up a build-bot type on a mac-mini that numpy hosts? (they can provide a login), you basically setup job that runs (could be a cron) and builds everything..?

@TomAugspurger
Copy link
Contributor Author

I'd be happy to, but I'll probably need help setting it up :)

@jreback
Copy link
Contributor

jreback commented Feb 24, 2014

see the bottom 2 comments on this thread: numpy/numpy#4328

email

rgommers privately and I think he can get you a login....then evaluate whether you think can be done.....thanks

@jreback
Copy link
Contributor

jreback commented Feb 24, 2014

@TomAugspurger also see this: having a whl for numpy would be nice for the mac (then you don't have to compile it!)

http://numpy-discussion.10968.n7.nabble.com/1-8-1-release-td36603.html

@TomAugspurger TomAugspurger deleted the sym_diff_nan3.4 branch May 15, 2017 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sym_diff failure on 3.4?
2 participants